benbhansen-stats / propertee

Prognostic Regression Offsets with Propagation of ERrors, for Treatment Effect Estimation (IES R305D210029).

Home Page:https://benbhansen-stats.github.io/propertee/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

convert tibbles to data frames?

benthestatistician opened this issue · comments

commented

In #173 Adam S addresses some trouble that can be traced to his use of tibbles. The immediate problem's been solved, but let's consider whether we want to check any data frames the user provided us for tibble-ness, and if so strip off the tibble class (so that our code doesn't get confused).

I'm on board with this. Any reason not to cast as.data.frame to all input?

commented

I couldn't think of any myself.

commented

The consensus being that this is a good idea, I've removed the discussion label here.