benadida / helios-server

Helios server

Home Page:http://heliosvoting.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Github authentication method

lizthegrey opened this issue · comments

As part of running the @open-telemetry elections, we'd like users to be able to directly log in with github rather than google credentials so we don't have to track down peoples' emails. Is a github auth provider a contribution you'd accept, @benadida?

very much so yes! Thank you for checking @lizthegrey.

can this be enabled on heliosvoting.org so I can close out this issue @benadida?

@lizthegrey sorry for the delay, just deployed and enabled this on prod. Let me know if you hit any snags! And thanks again for the contribution.

Great. I'll open a PR to be able to bulk upload a list of GH voters, and then we'll run the @open-telemetry election!

Fantastic!

this approach seem fine to you @benadida? #320

Bulk upload is merged, will close issue once released on https://vote.heliosvoting.org/

Verified working on vote.helios