Error is misleading when user was invited already
unRARed opened this issue · comments
It wasn't clear from the error on the form that I had already been previously invited to the Slack org. Appears to hit line 83 of invite.go.
Screenship:
@unRARed Thanks for posting an issue. I don't believe the client library we are currently (https://github.com/nlopes/slack) using exposes any machine-readable error code but will need to investigate this further. If this is the case there are two potential paths forward I see:
- Implement better error handling within nlopes/slack such that API errors can be inspected. Hopefully this would be accepted upstream so we would not need to maintain our own fork.
- Fetch the list of users and check for membership prior to submitting to the Slack API and check for membership.
My preference at this point would be #1, assuming it would be welcomed upstream.
It should also be noted that this affects the Mail Chimp signup as well.