Conflicting peer dependencies- clean run of `npm install` is failing.

Question

Conflicting peer dependencies- clean run of `npm install` is failing.

ben-p-commits opened this issue 2 years ago · comments

Ben P. commented 2 years ago

Environment

version: 0.1.0 - master
running on Mac OS 12.4, M1 Hardware
npm -v -> 8.15.0

Steps to reproduce (for bugs only)

clean clone of master branch, no changes to source. git status is clean.
run npm install in top dir of repo
peer dependency conflict error 💥

(I have attached logs)

Current Behavior

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: react-device-detect@1.17.0
npm ERR! Found: react@18.2.0
npm ERR! node_modules/react
npm ERR!   react@"^18.0.0" from the root project
npm ERR!   peer react@"^18.2.0" from react-dom@18.2.0
npm ERR!   node_modules/react-dom
npm ERR!     react-dom@"^18.0.0" from the root project
npm ERR!     peer react-dom@"^16.0.0-0 || ^17.0.0-0 || ^18.0.0-0" from react-portal@4.2.2
npm ERR!     node_modules/react-portal
npm ERR!       react-portal@"^4.2.0" from the root project
npm ERR!     2 more (react-twitter-embed, @testing-library/react)
npm ERR!   3 more (react-portal, react-twitter-embed, @testing-library/react)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@">= 0.14.0 < 18.0.0" from react-device-detect@1.17.0
npm ERR! node_modules/react-device-detect
npm ERR!   react-device-detect@"^1.6.2" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: react@17.0.2
npm ERR! node_modules/react
npm ERR!   peer react@">= 0.14.0 < 18.0.0" from react-device-detect@1.17.0
npm ERR!   node_modules/react-device-detect
npm ERR!     react-device-detect@"^1.6.2" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See ~/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!    ~/.npm/_logs/2022-08-12T21_59_45_584Z-debug-0.log

Expected Behavior

Successful installation of dependencies without conflicting dependencies.
eresolve-report.txt
2022-08-12T21_59_45_584Z-debug-0.log

eresolve-report.txt
2022-08-12T21_59_45_584Z-debug-0.log

Ben P. · Answer 1 · Sat Aug 13 2022 06:13:59 GMT+0800 (China Standard Time)

Tried downgrading to node v16.x.x per the note on the https://github.com/forensic-architecture/timemap readme.

Same issue.

Ben P. · Answer 2 · Sat Aug 13 2022 06:16:12 GMT+0800 (China Standard Time)

Issue seems 'resolved' when downgrading to v14.20.0- albeit with plenty of warnings. Will create a PR to note this in the readme of this repo.

Miguel Sozinho Ramalho · Answer 3 · Mon Aug 22 2022 18:58:22 GMT+0800 (China Standard Time)

Thanks @ben-palmer indeed node v14 is the most tested one here.

Logan Williams · Answer 4 · Sat Jan 14 2023 00:00:07 GMT+0800 (China Standard Time)

Hello @msramalho, @fspoettel, this is still an issue with the repository at present, preventing a clean install. This issue exists even with node v14.

Felix Spöttel · Answer 5 · Sat Jan 14 2023 00:15:52 GMT+0800 (China Standard Time)

@loganwilliams I'll take a look. Goal should be to have a working build on LTS?

Felix Spöttel · Answer 6 · Sat Jan 14 2023 00:42:13 GMT+0800 (China Standard Time)

@loganwilliams @msramalho I would like to do a related cleanup: the dependencies are a bit of a mess, a lot of things that should be devDeps are not. OK if I clean this up as well?