beakerbrowser / homebase

Self-deployable tool for hosting hyper:// websites

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Overly long Cache-Control max-age when mirroring to https

paul90 opened this issue · comments

When mirroring content to https the response contains a cache control with a max-age of 1 year.

'Cache-Control': 'public, max-age=31536000',

While for static content this is not a problem, for changing content if the browser has it in its cache the cached version will be used without checking with homebase to see if a more up to date version of the file is available.

As etag is set, and checked with the request, it would be better to set max-age=0, and let the match against If-None-Match in the request take effect.

Okay, I'd be 👍 with a PR to do that.