LED netdev trigger
jadonk opened this issue · comments
Jason Kridner commented
Please turn on the NETDEV and all the fun LED triggers. :-)
This is needed for BeagleBone AI WiFi link indication.
Drew Fustini commented
@jadonk @RobertCNelson did we do this?
Robert Nelson commented
Yes
Drew Fustini commented
drivers/leds/trigger/ledtrig-netdev.c
added in 4.14:
5f820ed52371 v5.5-rc1~98^2 leds: trigger: netdev: fix handling on interface rename
909346433064 v5.1-rc3~9^2 leds: trigger: netdev: use memcpy in device_name_store
4cb6560514fa v5.1-rc3~9^2~2 leds: trigger: netdev: fix refcnt leak on interface rename
f8112a1de1a7 v4.19-rc1~161^2~10 leds: netdev trigger: simplifications from core changes
2282e125a406 v4.19-rc1~161^2~15 leds: triggers: let struct led_trigger::activate() return an error code
06f502f57d0d v4.16-rc1~136^2~11 leds: trigger: Introduce a NETDEV trigger
Robert Nelson commented
it's been enabled, and shipped with teh bbai out of box image.
Drew Fustini commented
@RobertCNelson Ah, I was editing while you were writing. What did we add to the device tree for it?
Robert Nelson commented
Drew Fustini commented
led4 {
label = "beaglebone:green:usr4";
gpios = <&gpio3 7 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "netdev";
default-state = "off";
};
Drew Fustini commented
Thanks, I am out of phase :)
So close it?