bcnmy / scw-contracts

SCW contracts for Biconomy Smart Account

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Checking initializer.length

zakrad opened this issue · comments

Why does the SmartAccountFactory include a check for initializer.length > 0 in the deployAccount and deployCounterFactualAccount functions? Given that the initializer is not passed directly and is not optional. Under what circumstances would initializer.length be zero?

makes sense. I will link the pull request here (issue created internal tracker SMA 320)

Thanks again @zakrad for your contribution. We fixed the issues you pointed out. Your input was helpful in improving our project. 🙏