Module Manager: execTransactionFromModule does not emit module events

[zakrad]

I noticed that in the module manager's execTransactionFromModule function, it directly uses the _execute function from the executor contract. However, this setup doesn't emit any of module events when a transaction succeeds or fails.

I'm wondering why we're not using the _executeFromModule function, like we do in the execBatchTransactionFromModule method, for consistency.

[Adam Boudj]

Hey @zakrad 😊
thank you for pointing this out. The design choice was made for specific reasons, but your observation about consistency is valid. We'll review the implementation and consider making adjustments in future iterations. Thanks again your feedback is valuable to us! 👍

Can you please check and address this @filmakarov ? thanks

[livingrockrises]

we could potentially add below code here

if (success) {
            emit ModuleTransaction(msg.sender, to, value, data, operation);
            emit ExecutionFromModuleSuccess(msg.sender);
        } else {
            emit ExecutionFromModuleFailure(msg.sender);
        }

can check this diff view. will get it internally reviewed with the team
https://github.com/bcnmy/scw-contracts/pull/154/files

[zakrad]

It's also not possible to specify txGas for execTransactionFromModuleReturnData is it possible to update that also?

[Adam Boudj]

Thank you @zakrad for your valuable contribution. We have addressed the issues you brought to our attention and made the necessary fixes. Your input has been extremely helpful in improving our project.