bboe / farcy

A code review bot for github pull requests.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

ESLint does not throw useful errors

balloob opened this issue · comments

When the ESLint handler fails, it will currently raise a KeyError: 'ruleId' because the returned JSON does not match the expected output.

We should raise an appropriate error instead that contains the reason why ESLint failed to run.

Example output when an error occurs:

[
  {
    'errorCount': 1,
    'warningCount': 0,
    'filePath': '/tmp/tmpxsc5ni54/end_type_date.js',
    'messages': [
      {
        'fatal': True,
        'severity': 2,
        'column': 21,
        'message': 'Parsing error: Unexpected token =',
        'line': 23
      }
    ]
  }
]