Giters

bbc / wraith

Wraith — A responsive screenshot comparison tool

Home Page:http://bbc-news.github.io/wraith/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Wrong render on one of our pages, and I don't know why

kud opened this issue · comments

commented

Issue checklist:

  • I have validated my config file against YAML Validator to make sure it is valid YAML.

  • I have run the wraith info command and pasted the output below:

DEBUG: #################################################
DEBUG:   Command run:        info
DEBUG:   Wraith version:     4.2.3
DEBUG:   Ruby version:       ruby 2.5.3p105 (2018-10-18 revision 65156) [x86_64-darwin17]
DEBUG:   ImageMagick:        Version: ImageMagick 7.0.8-13 Q16 x86_64 2018-10-22 https://imagemagick.org
DEBUG:   PhantomJS version:  2.1.1
DEBUG:   chromedriver version:  ChromeDriver 2.40.565386 (45a059dc425e08165f9a10324bd1380cc13ca363)
DEBUG:   CasperJS version:   CasperJS not installed
DEBUG: #################################################
  • I have run the command in verbose mode (by adding verbose: true to my config) and pasted the output below:
DEBUG: Both images are exactly 480x800 - no cropping required. (__tests__/shots/contexte-off/480x800_chrome_dev.png, __tests__/shots/contexte-off/480x800_chrome_prod.png)
DEBUG: Cropping both images to 1024x8299. (__tests__/shots/contexte-off/1024_chrome_dev.png, __tests__/shots/contexte-off/1024_chrome_prod.png)
DEBUG: Cropping both images to 320x13642. (__tests__/shots/contexte-off/320_chrome_dev.png, __tests__/shots/contexte-off/320_chrome_prod.png)
DEBUG: Cropping both images to 1280x8187. (__tests__/shots/contexte-off/1280_chrome_dev.png, __tests__/shots/contexte-off/1280_chrome_prod.png)
DEBUG: Cropping both images to 768x9069. (__tests__/shots/contexte-off/768_chrome_dev.png, __tests__/shots/contexte-off/768_chrome_prod.png)
  • I have pasted the contents of my config file below:
browser: "chrome"

domains:
  prod:  "https://www.contexte.com"
  dev:   "xxx"

paths:
  # accueil:              /
  # pouvoirs:             /pouvoirs/
  # tous-les-hubs:        /pouvoirs/hubs/
  # briefing:             /briefing/
  contexte-off:         /off/ # a bit bugged, don't know why yet
  # data:                 /data/lois/
  # abonnement:           /abonnement/
  # abonnement-essai:     /abonnement/essai/
  # page-a-propos:        /pages/a-propos/
  # page-equipe:          /pages/equipe/
  # page-deonto:          /pages/charte-de-deontologie/
  # page-interets:        /pages/declaration-d-interets/
  # page-nous-suivre:     /pages/nous-suivre/

screen_widths:
  - 320
  - 480x800
  - 768
  - 1024
  - 1280

directory: '__tests__/shots'
fuzz: '20%'
threshold: 4
mode: diffs_first
verbose: true

Result:

image

  • dev:

320_chrome_dev

  • prod:

320_chrome_prod

The page: https://www.contexte.com/off/

commented

Okay I got it. Sorry for the disturbing. It's about "vh" in css and the content in my page. I have to fix this with a max-height. :)