bbc / simorgh

The BBC's Open Source Web Application. Contributions welcome! Used on some of our biggest websites, e.g.

Home Page:https://www.bbc.com/thai

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add Most read to WS articles pages (Test environment only)

JonBeeb opened this issue · comments

Is your feature request related to a problem? Please describe.
Add most read to amp article pages
Most read can be seen on canonical pages
https://www.bbc.com/kyrgyz/articles/c72x8jgx17do
but is missing from the AMP version
https://www.bbc.com/kyrgyz/articles/c72x8jgx17do.amp

The configuration for most read in the Simorgh config
https://github.com/bbc/simorgh/tree/latest/src/app/lib/config/services

mostRead: {
      header: 'De one we dem de read well well',
      lastUpdated: 'De one we dem update for:',
      numberOfItems: 10,
      hasMostRead: true,
    },

Describe the solution you'd like
Add most read to the AMP article pages.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Fallback
Don't show component if data fails to load. Might need to show placeholder instead because of the responsive layout. Could use amp-bind to hide the title if data does not load

Testing notes
[Tester to complete]

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Checklist

Additional context
Add any other context or screenshots about the feature request here.

We would need to review numeral font size and space on both canonical and amp. Need to look at removing the margin above the title after psammead migration (mobile breakpoints).
Screenshot 2022-05-03 at 16 59 33