bbc / react-transcript-editor

A React component to make correcting automated transcriptions of audio and video easier and faster. By BBC News Labs. - Work in progress

Home Page:https://bbc.github.io/react-transcript-editor

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Breaking change: `MediaPlayer` should be renamed `MediaControls`? `TransportControls`?

pietrop opened this issue · comments

A possible breaking change suggestion, MediaPlayer (see in storybook) should be renamed MediaControls?

Since over time it has become decoupled from the actual HTML5 video player element, wrapped in VideoPlayer component, then perhaps the name should be a bit more representative?

Raising it as an issue, as it might be a breaking change for backward compatibility.

Ah, interesting, had not seen this before, yeah, that would be a good name in line with existing conventions 👍