Giters

bbc / Imager.js

Responsive images while we wait for srcset to finish cooking

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[PROPOSAL] AMD Support

Integralist opened this issue · comments

commented

BBC's original implementation of Imager (known as Image Enhancer) was wrapped up as an AMD module so it could be loaded into other scripts using an AMD compatible loader script such as RequireJS or Curl.

Before we can re-introduce the new and improved Imager back into the BBC code base we'd need to ensure it is AMD compatible (currently it's not, it creates a global Imager property instead).

/cc @oncletom

commented

I guess it could be used to leverage the custom build, by making an imager/events module for example (cf. #25 and #30), and imager/strategy/replacer etc.

commented

We can close it as it's now done in #41