Kotlin Metadata is unchanged
thomasbao12 opened this issue · comments
Even using the latest commit 57067a1beec4ce5c7ee97ec25bb666b6fad6b160
, bazel_jar_jar will not update the kotlin metadata in the bytecode.
Repro:
jar_jar(
name = "graphql_kotlin_schema_generator_shaded",
inline_rules = ["rule graphql.** graphql13.@1"],
input_jar = "@maven//:com_expediagroup_graphql_kotlin_schema_generator",
visibility = ["//visibility:private"],
)
where this is the resolved maven coordinate: ("com.expediagroup", "graphql-kotlin-schema-generator", "1.0.0-RC11").
IF you look at the shaded jar, you'll see the following
![Screenshot 2024-01-24 at 4 30 00 PM](https://private-user-images.githubusercontent.com/19645812/299781145-5cc1470b-6a6e-4d66-80dd-d28406b01090.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE3NTQwNjEsIm5iZiI6MTcyMTc1Mzc2MSwicGF0aCI6Ii8xOTY0NTgxMi8yOTk3ODExNDUtNWNjMTQ3MGItNmE2ZS00ZDY2LTgwZGQtZDI4NDA2YjAxMDkwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIzVDE2NTYwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE5MTY4N2Q1M2Q1YzRlYjQyMDdmNDE3ZDAxZTY4YzRlZDdiNzE0MTQyMmU0OTgzYmEyOGRlMjU4MmFhN2JjMDgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.OmHyWCPVC7QaBN8Aj0kfwYDk3MF6nK34wuyhsP0Su9c)
![Screenshot 2024-01-25 at 2 18 58 PM](https://private-user-images.githubusercontent.com/19645812/299782719-41d52a11-9a51-4aa9-ac87-eb682f26a52d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE3NTQwNjEsIm5iZiI6MTcyMTc1Mzc2MSwicGF0aCI6Ii8xOTY0NTgxMi8yOTk3ODI3MTktNDFkNTJhMTEtOWE1MS00YWE5LWFjODctZWI2ODJmMjZhNTJkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIzVDE2NTYwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI4NWU3MzY4YWUxYTIyMmRkMjBkZmVkMjE0NDdmNGE0NDIwZTY4YTgzNzM5ZWVjY2JlNTJjNDYwZmE4MmIxODQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.bfMDUiZzY0NmigQfIz2KfIihjXBA_EGXVgA0RfYnhRw)
Note that the import statement is changed correctly, but the kotlin metadata d2 field is not.
This will lead to compilation errors, where the inferred type and expected type do not match.