bazelbuild / rules_nodejs

NodeJS toolchain for Bazel.

Home Page:https://bazelbuild.github.io/rules_nodejs/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[FR]: rules_nodejs 5.x release line stopped becoming node version updates

davido opened this issue · comments

What is the current behavior?

Gerrit Code Review project is still using the latest rules_nodejs 5.8.4 distribution.

We would still like to use the latest and greatest node version, e.g. we would like to say just that:

node_repositories(
    node_version = "20.9.0",
)

Describe the feature

Is there a better way, than to patch in place outdated `node_versions.bzl?

WORKSPACE

http_archive(
    name = "rules_nodejs",
    patch_args = ["-p1"],
    patches = ["//tools:rules_nodejs-5.8.4-node_versions_patch.bzl"],
    sha256 = "8fc8e300cb67b89ceebd5b8ba6896ff273c84f6099fc88d23f24e7102319d8fd",
    urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/5.8.4/rules_nodejs-core-5.8.4.tar.gz"],
)

See this CL: [1] for the reference.

[1] https://gerrit-review.googlesource.com/c/gerrit/+/392716

We don't have an intent to continue maintaining the 5.x branch, we just have automation for HEAD and cut releases from there. Can you upgrade to 6.0?

Can you upgrade to 6.0?

Thanks, we will try to update to rules_nodejs 6.x or right away to rules_js.