Expand list of attributes inspected when collecting license information
davidkurkov opened this issue · comments
Expected Behavior
LicensesInfo
/ LicenseInfo
will be collected by reviewing all attributes of objects passed in to the gather_licenses_info
aspect.
Actual Behavior
The list of attributes that are inspected for LicenseInfo
/ LicensesInfo
does not gather licenses for all third party libraries included in an android app binary.
Steps to Reproduce the Problem
- Use
gather_licenses_info
aspect to collect license information for yourdeps
Note: the same way as shown in this docstring
Specifications
-
We found including
exports
allows us to find significantly more licenses when building an android binary. -
Version: 0.0.3
-
Platform: Android
I'm sure there are more attributes that would be helpful to inspect as well. But conversely, there are likely attributes from which we would not want to collect license information for depending on the goal - i.e., if we wanted to only find licenses for libraries that are compiled into an app binary we wouldn't want to include attributes like exports_plugins
.
Much of this might be addressed in a code drop this week. Stay tuned.