[Bug]: c-ares

[Dimiter 'malkia' Stanev]

What happened?

INFO: From Compiling ares_init.c:
In file included from <built-in>:368:
<command line>(22,9): warning: '_WIN32_WINNT' macro redefined [-Wmacro-redefined]
   22 | #define _WIN32_WINNT 0x0600
      |         ^
<command line>(5,9): note: previous definition is here
    5 | #define _WIN32_WINNT 0x0601
      |         ^

Version

Development (host) and target OS/architectures:

Output of bazel --version: bazel 7.0.2 (through bazelisk)

Version of relevant rules from the WORKSPACE or MODULE.bazel file:
Not in there, but MODULE.bazel.lock has it at "c-ares~1.15.0", seems like I may have to manually upgrade to latest c-ares, and see about gprc using it

F:\p\malkia\opentelemetry-cpp>grep -i ares MODULE.*
MODULE.bazel.lock:        "com_github_cares_cares": "c-ares@1.15.0",
MODULE.bazel.lock:    "c-ares@1.15.0": {
MODULE.bazel.lock:      "name": "c-ares",
MODULE.bazel.lock:      "key": "c-ares@1.15.0",
MODULE.bazel.lock:      "repoName": "c-ares",
MODULE.bazel.lock:          "name": "c-ares~1.15.0",
MODULE.bazel.lock:            "https://github.com/c-ares/c-ares/releases/download/cares-1_15_0/c-ares-1.15.0.tar.gz"
MODULE.bazel.lock:          "strip_prefix": "c-ares-1.15.0",
MODULE.bazel.lock:            "https://bcr.bazel.build/modules/c-ares/1.15.0/patches/add_build_file.patch": "sha256-+SUCFxBIkR0GE9FRFPps/e6AnA9cQIGANBHK14UAKwQ=",
MODULE.bazel.lock:            "https://bcr.bazel.build/modules/c-ares/1.15.0/patches/module_dot_bazel.patch": "sha256-SVQeSrnvd7IishMhmg8S3PK6/6bbt1IqwVEqKDfdYgk="
MODULE.bazel.lock:          "com_github_cares_cares": {
MODULE.bazel.lock:              "name": "grpc~1.56.3.bcr.1~grpc_repo_deps_ext~com_github_cares_cares",
MODULE.bazel.lock:              "build_file": "@@grpc~1.56.3.bcr.1//third_party:cares/cares.BUILD",
MODULE.bazel.lock:              "strip_prefix": "c-ares-6360e96b5cf8e5980c887ce58ef727e53d77243a",
MODULE.bazel.lock:                "https://storage.googleapis.com/grpc-bazel-mirror/github.com/c-ares/c-ares/archive/6360e96b5cf8e5980c887ce58ef727e53d77243a.tar.gz",
MODULE.bazel.lock:                "https://github.com/c-ares/c-ares/archive/6360e96b5cf8e5980c887ce58ef727e53d77243a.tar.gz"

Language(s) and/or frameworks involved: C++
This project https://github.com/malkia/opentelemetry-cpp

How to reproduce

On Windows, with VS2019 toolset installed (v142), VS2022 could work too, but make sure v142 is there, and have LLVM+Git installed too.

> git clone https://github.com/malkia/opentelemetry-cpp
> cd opentelemetry-cpp
> otel_sdk_build.cmd

Any other information?

Searching for https://github.com/search?q=repo%3Abazelbuild%2Fbazel-central-registry%20WIN32_WINNT&type=code reveals

"-D_WIN32_WINNT=0x0600",

But newer versions of bazel already declare this to https://github.com/search?q=repo%3Abazelbuild%2Fbazel%20WIN32_WINNT&type=code

 "/D_WIN32_WINNT=0x0601",

So it seems the one on c-ares is not needed.
I don't promise, but I'll try to propose a PR with changes (I don't have super good experience using git/pr's, more like P4 guy)