Callback is not returning errors?

Question

Callback is not returning errors?

SamVerschueren opened this issue 9 years ago · comments

Hi, thanks for the library, works very well!

I was wondering why the callbacks in methods like convert, toBuffer, ... do not apply to the NodeJS callback style (err, result)? Is there any specific reason or would it be better to refactor this?

Maybe if we are refactoring this, add support for Promises as well?

Would be happy to do a PR. Just let me know what you think.

Eugene Terehov · Answer 1 · Thu Oct 01 2015 22:03:27 GMT+0800 (China Standard Time)

Thank you Sam!
Yes, of course. You are more than welcome to join and I would love to switch to promises.
Your support is highly appreciated! :-)

Sam Verschueren · Answer 2 · Thu Oct 01 2015 22:05:02 GMT+0800 (China Standard Time)

Alright, thank you for the feedback. If I find some time I will do a PR for this one.

Sam Verschueren · Answer 3 · Sat Oct 03 2015 18:29:43 GMT+0800 (China Standard Time)

Would you like to remove the callback entirely or support both?

Eugene Terehov · Answer 4 · Sat Oct 03 2015 18:31:15 GMT+0800 (China Standard Time)

Great, I also thought about that. I'd prefer to support both. :-)

Lekhnath Rijal · Answer 5 · Thu Dec 17 2015 13:45:16 GMT+0800 (China Standard Time)

Error first callback please.

Dustin Hoffner · Answer 6 · Fri May 19 2017 16:17:16 GMT+0800 (China Standard Time)

Already solved by #34. Just forgot to close.