batoulapps / adhan-js

High precision Islamic prayer time library for JavaScript

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Misalignment between arguments order in types file and implementation file

korbav opened this issue ยท comments

Salam Alaykum, I noticed a problem with the order of the arguments in the types file, I take profit from the fact we're releasing another version soon to add the Rounding: Rounding export to expose this little issue.

Adhan.d.ts

constructor(fajrAngle: number, ishaAngle: number, methodName?: string, ishaInterval?: number, maghribAngle?: number)

Adhan.js

constructor(methodName, fajrAngle, ishaAngle, ishaInterval, maghribAngle)

This leads to invalid suggestions being shown in IDEs :
image

๐ŸŽ‰ This issue has been resolved in version 4.2.1 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€