404 image is not showing for nested paths
vivekweb2013 opened this issue · comments
Describe the bug
The png graphic is showing correctly for 404 route only for the first level path. i.e https://batnoter.com/abc but it is not showing up for nested path i.e. https://batnoter.com/abc/xyz
Screenshots
Hi @vivekweb2013 I would like to work on this issue, sorry I have had previous academic related issues going on for a while.
sure @shikhar13012001
Let me share my analysis. It looks like it is only happening on the github pages not sure why. On local setup the image is showing properly even for the nested paths
May be changing the image path to web url should fix this issue. https://i.ibb.co/wprRPLF/404.png
@shikhar13012001 that would not be a nice fix. I'd like the resources to be served from same site rather than using external site urls. Since it will introduce a dependency on this external site
okay I understand, I will try to work on this issue.
hmm.. It seems like path is actually ../static/images/404...png, But I still don't know why is this happening.
@shikhar13012001 yeah this is strange
@vivekweb2013 Did you find a solution to it? I think the raw github url is only possibility here :(
@shikhar13012001 I did not get enough time to look at this issue but for now I think we can place the 404 image in public/images directory and hardcode the absolute root path i.e. /images/404.png
I think this will work because of the absolute path. So we can make these changes for now
@shikhar13012001 seems like the issue was cased by homepage: "." property set in package.json file. Removing it fixed the issue.
@shikhar13012001 seems like the issue was cased by
homepage: "."property set inpackage.jsonfile. Removing it fixed the issue.
Ohh thanks!! I didn't notice this.
Fixed