node remove should require a node name
seanjensengrey opened this issue · comments
riak-mesos node remove
will remove riak-default-1 by default when no name is provided.
On subsequent, rexecution
$ riak-mesos node remove
Resource at http://10.1.12.145:31936/api/v1/clusters/default/nodes/riak-default-1 was not found (Status Code: 404)
The command should require an explicit node name, for example
riak-mesos node remove --node riak-cluster-4
You're right, this should be a required argument. In which case, I think we
should promote it to a positional arg, not a switch: riak-mesos node remove riak-default-1
That's 7 less characters to type!
I'm tempted to suggest that this applies to all node commands (except add).
Thoughts?
On Sat, 6 Aug 2016, 13:41 Sean Jensen-Grey, notifications@github.com
wrote:
riak-mesos node remove
will remove riak-default-1 by default when no name is provided.
On subsequent, rexecution
$ riak-mesos node remove
Resource at http://10.1.12.145:31936/api/v1/clusters/default/nodes/riak-default-1 was not found (Status Code: 404)The command should require an explicit node name, for example
riak-mesos node remove --node riak-cluster-4
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#31, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ACBkRmKCz3Ka6SDHYZ4xNeVxflEOFiW0ks5qdHLhgaJpZM4JeQ0n
.
and if we have a bare
riak-mesos node remove
it should actually call
riak-mesos node list along with help output