Line 99 and 356 uses template strings

Question

Line 99 and 356 uses template strings

tunnckoCore opened this issue 8 years ago · comments

Charlike Mike Reagent commented 8 years ago

As we comment in some commit comments.

https://github.com/node-base/base-runner/blob/master/index.js#L99
https://github.com/node-base/base-runner/blob/master/index.js#L356

Just to don't forget it. I may send PR this weekend.

Jon Schlinkert · Answer 1 · Sat Feb 20 2016 08:23:15 GMT+0800 (China Standard Time)

👍 thanks a lot for this. will help me remember

Jon Schlinkert · Answer 2 · Sat Feb 20 2016 08:24:12 GMT+0800 (China Standard Time)

I have a lot of updates to push up for base-generators, so don't waste time on that one. if you have issues with generators resolving, hopefully those will be fixed by end of the weekend

Charlike Mike Reagent · Answer 3 · Sat Feb 20 2016 08:28:46 GMT+0800 (China Standard Time)

Haha, ookey, so I'll rest this weekend and wait. LOL. 👍

It's interesting how you remember so many things/repos - what to push, what not.. it's unreal. ;D

Jon Schlinkert · Answer 4 · Sun Mar 06 2016 04:14:00 GMT+0800 (China Standard Time)

I'm going to keep these in. We haven't had any issues created so far with 2k downloads or so. not that 2k is a lot of downloads, but if it was a major problem we would have heard about it by now. I'm still of the opinion that we should be supporting the move towards new versions of node.js.

we'll update the engines property in package.json to reflect this.