Gateway configuration should use the name instead of the classname

[Dario Govergun]

GatewayManager, line 50:

if(!isset($this->gateways[$class])){
            $gateway = $this->factory->create($class, null, $this->app['request']);
            $gateway->initialize($this->getConfig($class));
            $this->gateways[$class] = $gateway;
        }

The config gets checked for the classname instead of the gateways name. I think it should be:

if(!isset($this->gateways[$class])){
            $gateway = $this->factory->create($class, null, $this->app['request']);
            $gateway->initialize($this->getConfig($gateway->getName()));
            $this->gateways[$class] = $gateway;
        }

That way, I can pass a custom gateway without having to use the fully qualified name of the class on the config file...

Am I correct?

Thanks

[Sergey Pashkevich]

@barryvdh what do you think about @dpgover solution?

[Barry vd. Heuvel]

Think so indeed

[Sergey Pashkevich]

@barryvdh may I create a PR with this changes?

[Barry vd. Heuvel]

Sure

[Sergey Pashkevich]

@barryvdh please see PR

[Ammon Casey]

@barryvdh @siarheipashkevich this PR seems to break the default gateway configs. see my comment here.

[Barry vd. Heuvel]

Reverted