PKCE Validation Failure

Question

PKCE Validation Failure

dshanske opened this issue 4 years ago · comments

Tried your code with my WordPress endpoint and am getting a PKCE validation failure. I've had PKCE for a while and it does work with other PKCE clients.

Jamie Tanna · Answer 1 · Mon Dec 14 2020 04:31:25 GMT+0800 (China Standard Time)

@barryf is resolving this now! ea34630 should resolve it, just waiting for it to be deployed 👍

Barry Frost · Answer 2 · Mon Dec 14 2020 04:36:27 GMT+0800 (China Standard Time)

Hey @dshanske! Thanks for testing. ea34630 has been deployed now. Would you mind trying again?

Jamie Tanna · Answer 3 · Mon Dec 14 2020 04:41:58 GMT+0800 (China Standard Time)

I'm still seeing 400s, just trying to step through manually to verify what's going wrong 👍

Barry Frost · Answer 4 · Mon Dec 14 2020 04:47:03 GMT+0800 (China Standard Time)

Ah. I'll take a closer look.

Barry Frost · Answer 5 · Mon Dec 14 2020 06:38:00 GMT+0800 (China Standard Time)

For reference:

https://tools.ietf.org/html/rfc7636#appendix-A

Barry Frost · Answer 6 · Tue Dec 15 2020 04:03:47 GMT+0800 (China Standard Time)

There's a new release on a temporary staging URL with a fix that passes the example in the RFC.

If you've got time to check @jamietanna or @dshanske then would you mind trying: https://mpubl-br-master.herokuapp.com/

Jamie Tanna · Answer 7 · Tue Dec 15 2020 04:05:53 GMT+0800 (China Standard Time)

LGTM! I've authenticated successfully 🙌

Barry Frost · Answer 8 · Tue Dec 15 2020 04:27:29 GMT+0800 (China Standard Time)

Awesome! Thanks @jamietanna 😄

I had found an implementation in Ruby that I now realise didn't work and copied it over. Lesson learned!

As well as the IndieAuth changes I've also added support for properties via q=config which I think your server supports. Does it work for your config?

Barry Frost · Answer 9 · Tue Dec 15 2020 04:38:15 GMT+0800 (China Standard Time)

Closing this issue following successful authorisations using three separate servers.