Ed25519 private key sk is not defined
mathcrypto opened this issue · comments
In the ed25519 test example, the private string sk is used to generate the public key (see https://github.com/barryWhiteHat/baby_jubjub_ecc/blob/master/tests/ed25519.py#L172 )and also the signature but its value was not defined.
I think sk is defined https://github.com/barryWhiteHat/baby_jubjub_ecc/blob/master/tests/test_eddsa.py#L47
Is this what you mean?
Also my general disclaimer. This is POC code. Check out
https://github.com/harryR/ethsnarks
or
https://github.com/iden3/circomlib/blob/master/circuits/eddsa.circom
For production implementations. That have been reviewed and optimized more.
Thank you, I meant it was not defined here https://github.com/barryWhiteHat/baby_jubjub_ecc/blob/master/tests/ed25519.py
I am not sure which instance you are talking about
Both signature(m,sk,pk) and def publickey(sk) pass sk as parameter when the function is called.
Do you get an error? Sorry I am probably missing something.
Ah I tried to run
https://github.com/barryWhiteHat/baby_jubjub_ecc/blob/master/tests/ed25519.py test alone that's why it did not work, but when I run all tests together it works fine. Thanks
No problem. Happy to help.
I would recommend building with one of the more maintinted languges.
If you have more questions feel free to reach out here or on gitter. Also I would be intersted to hear what you are working on.
feel free to close this issue if its resolved.