Giters

barakwei / ParticlePapertrail

Papertrail logging handler for Particle platforms

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add #error when compiling for FW version < 0.6.0

ScruffR opened this issue · comments

commented

If you want to publish this lib on Build, you might need to change your include statement in papertrail.cpp from

#include "papertrail/papertrail.h"

to this

#include "papertrail.h"

inside the samples the first version is correct.

For (soon to be released) Libraries 2.0 that confusion will be sorted ;-)

And to prevent confusion you might want to add a note in the sample code comment section and some explicit compile time warning #if (SYSTEM_VERSION < 0x00060000), since log handlers are only available from 0.6.0 onwards.

commented

Thanks for your feedback!
The library is published on build and it seems to be working, what am I missing?
I'll add a #error in the header file in case FW version is too low.

commented

I can't see it on Build. Have you published it, or have you still got the private flag next to the library name?

commented

Looks like the eye is open, should be OK, right?
image

commented

Very odd, I've cleared my cache, refreshed libraries and used incognito mode but can't find it.
Can you post a link to the library in build?

commented

Thanks, that helped and yes, it does build as is - so disregard what I said about the papertrail.cpp.
I was sure this would not have worked (in the past 😊)

Anyway nice job 👍

commented

It's still weird that you don't see the library in the list. I actually can't see it now, but sometimes I see "My libraries" category with the library.

commented

This is fixed in 0.0.2