banzaicloud / banzai-charts

Curated list of Banzai Cloud Helm charts used by the Pipeline Platform

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Thanos] Sidecar selector default values broke with kube-prometheus-stack 16.1.x

auricom opened this issue · comments

Describe the bug
Prometheus community changed prometheus nodelabel in Helm Chart 16.1.x
prometheus-community/helm-charts@2411d15#diff-a5376d240d3c8079c0639e2ca8ff06c837a7c8db7e7529415a637423934977a1

Banzaicloud Thanos helm chart is forcing to use the old naming convention https://github.com/banzaicloud/banzai-charts/blob/master/thanos/values.yaml#L1060, making sidecar service to not be attached to prometheus containers

Expected behavior
Default sidecar selector default values should be erasable