syntax highlighting not working

Question

syntax highlighting not working

carmen-gh opened this issue a year ago · comments

Hi, thanks for this awesome tool.
I use it everyday in lazygit.

I wonder how the syntax highlighting is working.
My kotlin code is not highlighted and I wonder if there is a fix a can do on my machine or if it needs to be supported by the tool.

Carmen Geelhaar · Answer 1 · Wed Aug 23 2023 04:38:05 GMT+0800 (China Standard Time)

https://github.com/shikijs/shiki/blob/v0.9.3/docs/languages.md#literal-values
kotlin is listed as supported language in shiki

Shrey Banga · Answer 2 · Mon Sep 04 2023 09:38:18 GMT+0800 (China Standard Time)

Hey, glad you like it! This is happening because I use the file extension as the language name passed to shiki, which usually works because shiki has aliases from file extensions to languages (e.g. 'rs' for rust), but it doesn't for Kotlin.

A PR like shikijs/shiki#353 adding aliases: ['kt'] for kotlin should resolve this issue if you feel comfortable doing that. If not, I can take a stab at it.

Carmen Geelhaar · Answer 3 · Mon Sep 04 2023 16:59:40 GMT+0800 (China Standard Time)

Thanks, yes I will definitely take the opportunity and create a PR

Carmen Geelhaar · Answer 4 · Mon Oct 02 2023 02:25:26 GMT+0800 (China Standard Time)

shikijs/shiki#525

Carmen Geelhaar · Answer 5 · Wed Oct 11 2023 15:40:02 GMT+0800 (China Standard Time)

@banga It got merged into https://github.com/shikijs/shiki/releases/tag/v0.14.5

Shrey Banga · Answer 6 · Thu Oct 12 2023 10:59:50 GMT+0800 (China Standard Time)

Great! I just bumped the shiki version to pick this up and checked that kotlin files highlight correctly now. I released v0.17.0, which you should be able to update to via npm i -g git-split-diffs.