Package @bam.tech/react-native-make has been ignored because it contains invalid configuration

Question

Package @bam.tech/react-native-make has been ignored because it contains invalid configuration

mcoeur opened this issue 5 years ago · comments

Hello,

Context :
Platform : MacOS

$react-native -v
react-native-cli: 2.0.1
react-native: 0.60.4

I get this error when i run the following command :

react-native set-splash --path src/assets/logo.png --background "#f9f4f0" --resize center

warn Package @bam.tech/react-native-make has been ignored because it contains invalid configuration. Reason: Cannot find module '/Users/mcoeur/Documents/Dev/MyApp/node_modules/@react-native-community/cli/package.json'
Require stack:
- /Users/mcoeur/Documents/Dev/MyApp/node_modules/@bam.tech/react-native-make/dist/rn-plugin.config.js
- /Users/mcoeur/Documents/Dev/MyApp/node_modules/@bam.tech/react-native-make/react-native.config.js
- /Users/mcoeur/Documents/Dev/MyApp/node_modules/import-fresh/index.js- /Users/mcoeur/Documents/Dev/MyApp/node_modules/cosmiconfig/dist/loaders.js
- /Users/mcoeur/Documents/Dev/MyApp/node_modules/cosmiconfig/dist/createExplorer.js
- /Users/mcoeur/Documents/Dev/MyApp/node_modules/cosmiconfig/dist/index.js
- /Users/mcoeur/Documents/Dev/MyApp/node_modules/react-native/node_modules/@react-native-community/cli/build/tools/config/readConfigFromDisk.js
- /Users/mcoeur/Documents/Dev/MyApp/node_modules/react-native/node_modules/@react-native-community/cli/build/tools/config/index.js
- /Users/mcoeur/Documents/Dev/MyApp/node_modules/react-native/node_modules/@react-native-community/cli/build/commands/install/install.js
- /Users/mcoeur/Documents/Dev/MyApp/node_modules/react-native/node_modules/@react-native-community/cli/build/commands/index.js
- /Users/mcoeur/Documents/Dev/MyApp/node_modules/react-native/node_modules/@react-native-community/cli/build/cliEntry.js
- /Users/mcoeur/Documents/Dev/MyApp/node_modules/react-native/node_modules/@react-native-community/cli/build/index.js
- /Users/mcoeur/Documents/Dev/MyApp/node_modules/react-native/cli.js
- /Users/mcoeur/.nvm/versions/node/v12.8.0/lib/node_modules/react-native-cli/index.js
error Unrecognized command "set-splash".
info Run "react-native --help" to see a list of all available commands.

I followed this blog post to install everything : https://blog.bam.tech/developper-news/set-up-your-react-native-splash-screen-in-15-minutes

What did I miss ?

Yann Leflour · Answer 1 · Wed Sep 25 2019 15:48:54 GMT+0800 (China Standard Time)

Linked to #6 , plugin is currently incompatible with npm (yarn only) a fix is being developed

Tony · Answer 2 · Mon Oct 07 2019 14:27:01 GMT+0800 (China Standard Time)

I'm still having this problem using 1.0.3 and react-native set-splash --path logo.png --resize center.

warn Package @bam.tech/react-native-make has been ignored because it contains invalid configuration. Reason: Unexpected token {

Installed using yarn add -D @bam.tech/react-native-make.

react-native-cli: 2.0.1
react-native: 0.61.1

At first I installed it on react-native 0.60.5, uninstalled it, upgraded to 0.61.1, reinstalled but still have the same issue. I don't see the commands in react-native -h either.

Yann Leflour · Answer 3 · Mon Oct 07 2019 15:49:01 GMT+0800 (China Standard Time)

Thanks for the feedback. I will try making this plugin available through command line under the `rnmake` alias

…

On Mon, Oct 7, 2019, 08:27 Tony ***@***.***> wrote: I'm still having this problem using 1.0.3 and react-native set-splash --path logo.png --resize center. warn Package @bam.tech/react-native-make has been ignored because it contains invalid configuration. Reason: Unexpected token { Installed using yarn add -D @bam.tech/react-native-make. react-native-cli: 2.0.1 react-native: 0.61.1 At first I installed it on react-native 0.60.5, uninstalled it, upgraded to 0.61.1, reinstalled but still have the same issue. I don't see the commands in react-native -h either. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#11?email_source=notifications&email_token=AAOG6JLIJCDHFVTLIY7UU6LQNLJDLA5CNFSM4IZ4PQT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAPE4EA#issuecomment-538856976>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAOG6JNCZMLJDKBPPB7Z5HDQNLJDLANCNFSM4IZ4PQTQ> .

dimp · Answer 4 · Thu Oct 10 2019 07:36:53 GMT+0800 (China Standard Time)

@huangtony try to use v1.02 yarn add -D @bam.tech/react-native-make@1.0.2
It worked with react-native version 0.61.2

Tony · Answer 5 · Thu Oct 10 2019 19:45:27 GMT+0800 (China Standard Time)

@logicallydimp23 Thanks, v1.02 worked fine.

Yann Leflour · Answer 6 · Fri Oct 11 2019 00:29:04 GMT+0800 (China Standard Time)

Hello, @mcoeur , can you tell me your react-native-cli package.json local install path within your project? It seems that I haven't handled all possibilities

tomeberle · Answer 7 · Sat Oct 12 2019 03:22:53 GMT+0800 (China Standard Time)

Having this issue as well with RN 0.60.5 / npm install..

dimp · Answer 8 · Wed Oct 23 2019 19:43:12 GMT+0800 (China Standard Time)

Having this issue as well with RN 0.60.5 / npm install..

@tomeberle as a workaround have you tried v1.0.2?
yarn add -D @bam.tech/react-native-make@1.0.2

tomeberle · Answer 9 · Wed Oct 23 2019 19:55:53 GMT+0800 (China Standard Time)

@logicallydimp23 Yes, but I had issues as well as the project is using npm and not yarn. Specifically, the yarn install was failing on MS Appcenter.

Yann Leflour · Answer 10 · Mon Nov 25 2019 19:24:09 GMT+0800 (China Standard Time)

@logicallydimp23 Can you give me:

Using npm or yarn?
Which version ?
Which react-native-cli version ?
Which react-native (project version) ?

Yann Leflour · Answer 11 · Mon Nov 25 2019 19:37:07 GMT+0800 (China Standard Time)

By the way, I need all the help I can get solving this issue.

For your information, previous invalid configuration errors were because @react-native-community/cli/package.json couldn't be resolved.

Currently supported paths (cwd is your react-native project directory):

node_modules/@react-native-community/cli/package.json (yarn)
node_modules/react-native/node_modules/@react-native-community/cli/package.json (npm)

If your path doesn't match either of those, can you tell me:

What your path actually is
What your os, node, npm, yarn, RN, RN-cli versions are

dimp · Answer 12 · Tue Nov 26 2019 07:36:37 GMT+0800 (China Standard Time)

@yleflour

Using npm or yarn? Yarn
Which version ? Yarn v1.17.3, @bam.tech/react-native-make v1.0.2
Which react-native-cli version ? react-native-cli: 2.0.1
Which react-native (project version) ? react-native: 0.60.5

Finn Pauls · Answer 13 · Wed Nov 27 2019 01:33:05 GMT+0800 (China Standard Time)

I went to the node_modules/@bam.tech/react-native-make/dist/rn-plugin.config.js file and removed the V1 detection script:

"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
require("colors");
const modules_1 = require("./modules");
const path_1 = require("path");
const rn_compatibility_layer_1 = require("./rn-compatibility-layer");
const v2Config = {
    commands: [modules_1.setIconCommand, modules_1.setSplashScreenCommand],
};
exports.rnPluginConfig = v2Config;

After that it was working correctly.

Maybe you can just deprecate v1?