bamlab / react-native-flipper-performance-monitor

An attempt to have a lighthouse for React Native. Flipper plugin to show a graph of the React Native performance monitor

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Question regarding performance

CallumHemsley opened this issue · comments

Hello!

We've been using this flipper plugin to monitor our performance and it's worked quite well so far!

One question we have is does tracking performance have an impact on performance? We were wondering if this should be turned on conditionally or something, or do we always want it running in prod?

Thanks!

Hi @CallumHemsley

Glad to hear it's working well for you :)

No impact on production, the plugin doesn't do anything in production.

  • On Android, it's only included in the debug build type with debugImplementation
  • On iOS it shouldn't run since it's wrapped in the FB_SONARKIT_ENABLED flag. Also #62 in v0.3.1 ensures it's not even installed in production

For black-box performance testing for production builds, https://github.com/bamlab/android-performance-profiler is also having a bit of a revamp... More on that soon!

Amazing, thanks Alex!