Giters

bamlab / react-native-flipper-performance-monitor

An attempt to have a lighthouse for React Native. Flipper plugin to show a graph of the React Native performance monitor

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Installation error

Abramovick opened this issue · comments

commented

In ReactNativeFlipper.java file i think i need to import the library before doing client.addPlugin(new RNPerfMonitorPlugin(reactInstanceManager)). I'm not sure what the import package link is.... That's just my guess anyways, I'm not a java guy (I'm more javascript so maybe I'm wrong).

I get the error

/ReactNativeFlipper.java:48: error: cannot find symbol
      client.addPlugin(new RNPerfMonitorPlugin(reactInstanceManager));
                           ^
  symbol:   class RNPerfMonitorPlugin
  location: class ReactNativeFlipper
Note: /.../android/app/src/debug/java/com/safiri/ReactNativeFlipper.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
1 error

FAILURE: Build failed with an exception.
commented

Hi @Abramovick , import should be:

import tech.bam.rnperformance.RNPerfMonitorPlugin;

I'll add this to the doc

(Usually I just open the android folder on Android Studio, then you get auto imports when you add code)

commented

@Almouro thanks man.

Ooooh, that's why. I don't like firing up Android Studio because it's too heavy, so i usually use VSCode & command line.
And yes, please do stick it in the docs.