Use production build for walt-explorer

Question

Use production build for walt-explorer

JobLeonard opened this issue 6 years ago · comments

Feature Request

Build the explorer website with production settings before putting it on-line

Overview

Currently the walt-explorer is using the dev build on the website. As a result, it's a 5mb JS file. I'm pretty sure it can be reduced to a fraction of that (not to mention run significantly faster) by instructing webpack to create a production build before publishing it on the website.

Perhaps the the minification pluginsbreak the walt code, but you should be able to run webpack without them and even then it will improve the payload.

Impact

Small to medium. Mostly it's just ironic to have a bloated website for a tool to make low-level fast WASM :P

randy7d0 · Answer 1 · Wed Oct 17 2018 21:21:32 GMT+0800 (China Standard Time)

One question: does walt-explorer (and other WALT modules) uses Webpack version 3.x?

The reason I asked is I started looking into supporting production build. I managed to reduce size from ~5MB -to- ~2.6MB. This does NOT uses any of the Webpack 4.x features such as compression, minification etc.

Please confirm so I could raise PR for my changes. Thanks!

Arthur Buldauskas · Answer 2 · Wed Oct 17 2018 21:59:58 GMT+0800 (China Standard Time)

Yes, it's an older version of Webpack (4+ was on its way to release at the time).

There isn't any good reason for 3.x so feel free to upgrade if you are up for it. Thanks!

randy7d0 · Answer 3 · Thu Oct 18 2018 06:45:59 GMT+0800 (China Standard Time)

Thanks for confirming it!

I would submit PR with what I have done so far that gives ~50% reduction in size.

Later on, I will give it a try to upgrade it to 4.x. For that, perhaps we can create a new feature story.

randy7d0 · Answer 4 · Tue Oct 23 2018 15:10:26 GMT+0800 (China Standard Time)

Hi moderator, can you please give me 'Write' access in order for me to submit PR for this story. Thanks!

Arthur Buldauskas · Answer 5 · Tue Oct 23 2018 22:03:36 GMT+0800 (China Standard Time)

You do not need write access to make a PR. If you cloned the repo locally, then you'll need to create a fork, push your changes to that remote instead and create a PR from there.

https://help.github.com/articles/creating-a-pull-request-from-a-fork/

randy7d0 · Answer 6 · Fri Oct 26 2018 14:14:37 GMT+0800 (China Standard Time)

I have created the following pull request, please help to review it. Thanks!
#170

randy7d0 · Answer 7 · Sat Oct 27 2018 08:45:01 GMT+0800 (China Standard Time)

I could not find anyone whom I can assign as 'Reviewer', however. So, what is the process of doing actual submission (merging to master branch) for this? Please suggest. Thanks!

Arthur Buldauskas · Answer 8 · Sat Oct 27 2018 11:20:55 GMT+0800 (China Standard Time)

I will review it and merge it as soon as I have a chance (within a day or so), thanks!

randy7d0 · Answer 9 · Sun Oct 28 2018 08:03:44 GMT+0800 (China Standard Time)

I have updated based on feedback. Please have a look again. Thanks!
#170 (review)

Job van der Zwan · Answer 10 · Thu Nov 22 2018 03:36:44 GMT+0800 (China Standard Time)

I think #176 is relevant to this topic ;)