balancer / balancer-core

Balancer on the EVM

Lack of events in setBLabs is error-prone

montyly opened this issue 4 years ago · comments

Feist Josselin commented 4 years ago

Severity: Informational
Difficulty: Low

Description

BFactory.setBLabs changes the blabs address without emitting an event:

https://github.com/balancer-labs/balancer-core/blob/942a51e202cc5bf9158bad77162bc72aa0a8afaf/contracts/BFactory.sol#L51-L54

The lack of events makes more difficult to track potential error or compromise.

Recommendation

Add an event to BFactory.setBLabs

Mike McDonald commented 4 years ago

Fixed

https://github.com/balancer-labs/balancer-core/blob/6e12aef75749633165b96689eb34e96692eda872/contracts/BFactory.sol#L63-L69