Lint and test standardization
mikemcdonald opened this issue · comments
- Set up solhint for solidity
- Set up eslint for test cases
Test math should use bignumber.js and keep numbers in standard form. Meaning comparisons should not be done on the 10**18 scale. Math should be calculated separately and compared to the fromWei() results from the EVM
Documentation should be added to map out ranges of precision loss due to approximations for joins,swaps,exits
Use decimal.js over bignumber.js for non-integer exponent support