Giters

badaix / snapweb

Web interface for Snapcast

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Support for showing disconnected devices / Removing stale devices

tgurr opened this issue · comments

commented

When making use of the Play button of the Snapweb web client a new client is created and they may end up piling up when using different browsers/devices/sessions so it would be great to be able to add a toggle to display disconnected devices and also have the ability to remove them because having to edit the server.json manually to get rid of them is quite cumbersome.

commented

I would like to have a menu for this, similar to the one in Snapdroid, a button with three dots or a hamburger button that opens a context menu with an "about..." option and a "[x] show hidden clients" checkbox.
It's not there yet, because I'm by far not an expert in web development (this is my first web project), and without using a framework (not needed so far, will keep the site small), it's quite some fiddly task.
What you can do is replacing in line 278 of snapcontrol.js

let hide_offline = true;

with

let hide_offline = false;

It should also show a button to remove the clients for each offline client

commented

@badaix Seems like you're potentially interested in accepting PRs? If so, a few questions:

  • are you interested in refactoring PRs?
  • do you have any browser support goals - eg. IE11?
commented

Of course, I'm accepting PRs. General design goals are to keep it small and simple and to run on relevant browsers, including iOS.

commented

@badaix Are you against using any framework in this project? I see #32 proposed Vue, albeit with lots of extra changes. Something modern but lightweight could be beneficial having reviewed the source.