🚀 Entity Feedback Plugin: Providing multiple feedbacks per entity

[MBrettschneider]

Plugin Name

Entity Feedback Plugin

🔖 Feature description

It might be that a user wants to provide multiple feedbacks. Currently, the old feedback gets overwritten. Instead, it should be listed as an additional feedback.

🎤 Context

In my use-case, I would expect that entities could have multiple issues, found by one user in multiple usages of the entity.

✌️ Possible Implementation

No response

👀 Have you spent some time to check if this feature request has been raised before?

• I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

• I have read the Code of Conduct

Are you willing to submit PR?

No, I don't have time to work on this right now

[Phil Kuang]

Thanks for requesting this issue - I think it makes sense to allow this as an option for configuring this plugin.

I think this can be supported by making a simple change to the current ratings components:

community-plugins/workspaces/entity-feedback/plugins/entity-feedback/src/components/LikeDislikeButtons/LikeDislikeButtons.tsx

Lines 72 to 90 in ff24f6e

 const { loading: loadingFeedback } = useAsync(async () => { 
   // Wait until entity is loaded 
   if (!entity) { 
     return; 
   } 
  
   try { 
     const identity = await identityApi.getBackstageIdentity(); 
     const prevFeedback = await feedbackApi.getRatings( 
       stringifyEntityRef(entity), 
     ); 
     setRating( 
       (prevFeedback.find(r => r.userRef === identity.userEntityRef)?.rating ?? 
         rating) as FeedbackRatings, 
     ); 
   } catch (e) { 
     errorApi.post(e as ErrorApiError); 
   } 
 }, [entity, feedbackApi, setRating]); 

community-plugins/workspaces/entity-feedback/plugins/entity-feedback/src/components/StarredRatingButtons/StarredRatingButtons.tsx

Lines 71 to 92 in ff24f6e

 const { loading: loadingFeedback } = useAsync(async () => { 
   // Wait until entity is loaded 
   if (!entity) { 
     return; 
   } 
  
   try { 
     const identity = await identityApi.getBackstageIdentity(); 
     const prevFeedback = await feedbackApi.getRatings( 
       stringifyEntityRef(entity), 
     ); 
  
     const prevRating = prevFeedback.find( 
       r => r.userRef === identity.userEntityRef, 
     )?.rating; 
     if (prevRating) { 
       setRating(parseInt(prevRating, 10)); 
     } 
   } catch (e) { 
     errorApi.post(e as ErrorApiError); 
   } 
 }, [entity, feedbackApi, setRating]); 

A component prop can probably be added to disable the hooks above - something like showPreviousRating = false, defaulted to true to preserve current behavior. This should allow a user to enter a new rating every time they visit the entity since the backend should already handle persisting each submission appropriately timestamped.

It should be a relatively straightforward change if someone is willing to contribute this enhancement 🙂

[Yash Oswal]

You might want to take a look at https://www.npmjs.com/package/@janus-idp/backstage-plugin-feedback