babel / babylon

PSA: moved into babel/babel as @babel/parser -->

Home Page:https://github.com/babel/babel/tree/master/packages/babel-parser

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Flow & TypeScript should not have overlapping node types

jamiebuilds opened this issue · comments

Right now both the flow plugin and the typescript plugin create these nodes:

  • TypeParameterInstantiation
  • TypeParameterDeclaration
  • TypeParameter

And there is no way to tell the difference between them other than looking up the parserOpts which is unreliable since there are places you can't access the parserOpts.

It sucks that Flow node types aren't prefixed, but TypeScript ones should definitely all be.

Could we prefix these all with TS*?

I'm going to close this and move to #710