babel / babylon

PSA: moved into babel/babel as @babel/parser -->

Home Page:https://github.com/babel/babel/tree/master/packages/babel-parser

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

TypeScript: Modifiers not included in range of TSParameterProperty

JamesHenry opened this issue · comments

Input Code

Example of existing fixture in babylon tests:

class C {
    constructor(
        readonly r,
        public pu: number,
        protected po?,
        private pi?: number,
        public readonly pur,
        // Also works on AssignmentPattern
        readonly x = 0,
        public y?: number = 0) {}
}

The TypeScript plugin for babylon currently does not include the modifiers (readonly, public etc) within the location data for the relevant TSParameterProperty node.

This is not the case in the TypeScript compiler for the equivalent Parameter node, and also not in typescript-eslint-parser.

@andy-ms If you agree that this should be changed, I can work on this.

This issue has been moved to babel/babel#6679.