babel / babel-preset-env

PSA: this repo has been moved into babel/babel -->

Home Page:https://github.com/babel/babel/tree/master/packages/babel-preset-env

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add support for Samsung Internet browser

philipwalton opened this issue · comments

Samsumg Internet uses Chromium under the hood, but it doesn't always stay up-to-date with the latest version. We discovered this recently due to a bug report from a Samsung Internet user.

To fix it, we had to investigate the version of Chromium they use and then manually add that to the browser list:

const babelPlugin = babel({
  presets: [['env', {
    targets: {
      browsers: ['chrome >= 51'],
    },
    // ...
});

But this requires a bit or work on the user's side. Since browserlist support Samsung Internet, ideally we'd be able to do this:

const babelPlugin = babel({
  presets: [['env', {
    targets: {
      browsers: ['last 2 Samsung versions'],
    },
    // ...
});

I haven't looked into whether this can be done solely on the babel-preset-env side, or if it would require changes to http://kangax.github.io/compat-table. If the latter is the case, maybe we can loop in @poshaughnessy for help making that happen?

@philipwalton we could maybe create a mapping similar to electron-to-chromium which powers our electron targets?

@existentialism seems like something like that could work well. I wonder if other browserlist consumers already have a solution in place to handle Samsung Internet.

This issue has been moved to babel/babel#6602.