Giters

azuline / repertoire

whoops never finished this lol, don't look it's old and embarrassing

Home Page:https://repertoire.readthedocs.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

resolve useEffect dependency array issues

azuline opened this issue · comments

commented

The site works okay (at least for my normal usage) with these missing dependencies. When added, these dependencies create an infinite loop.

Figure out what to do...

./src/hooks/pagination.ts
  Line 59:6:  React Hook React.useEffect has missing dependencies: 'history' and 'query'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

./src/hooks/audio.ts
  Line 85:6:  React Hook React.useEffect has missing dependencies: 'audio' and 'nextAudio'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

These warnings are why CI is failing.