'out-of-line definition of 'GetFieldName' does not match any declaration in 'ResultSet''

Question

'out-of-line definition of 'GetFieldName' does not match any declaration in 'ResultSet''

LucasGitDev opened this issue 4 years ago · comments

Lucas Teles de Souza commented 4 years ago

SMALL DESCRIPTION:

After downloading eluna-mod I tried to recompile "<cmake ../ -DCMAKE_INSTALL_PREFIX=/home/noob/azeroth-server/ -DCMAKE_C_COMPILER=/usr/bin/clang -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DTOOLS=0 -DSCRIPTS=1 -DWITH_WARNINGS=1 -DCMAKE_C_FLAGS="-Werror" -DCMAKE_CXX_FLAGS="-Werror">" and when I used 'sudo make -j 6' I got the image error

https://ibb.co/tm3tjgK

EXPECTED BLIZZLIKE BEHAVIOUR:

before the error was normal

CURRENT BEHAVIOUR:

just don't recompile

STEPS TO REPRODUCE THE PROBLEM:

Install mod-eluna from https://github.com/azerothcore/mod-eluna-lua-engine
Try recompile using: cmake ../ -DCMAKE_INSTALL_PREFIX=/home/noob/azeroth-server/ -DCMAKE_C_COMPILER=/usr/bin/clang -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DTOOLS=0 -DSCRIPTS=1 -DWITH_WARNINGS=1 -DCMAKE_C_FLAGS="-Werror" -DCMAKE_CXX_FLAGS="-Werror"
Use: sudo make -j 6
got the error

EXTRA NOTES:

BRANCH(ES):

master

AC HASH/COMMIT:

2743874e5da893c18f6ae19f88dcf944cf4cfc8b

OPERATING SYSTEM:

Ubuntu 18.04

MODULES:

https://github.com/azerothcore/mod-eluna-lua-engine

OTHER CUSTOMIZATIONS:

no other

Francesco Borzì commented 4 years ago

moved

Kitzunu commented 4 years ago

@Rochet2

Lucas Teles de Souza · Answer 1 · Thu May 28 2020 23:09:57 GMT+0800 (China Standard Time)

did eluna-mod cause this?

Kaiser · Answer 2 · Sat May 30 2020 13:54:55 GMT+0800 (China Standard Time)

no fix yet?

Rochet2 · Answer 3 · Sun May 31 2020 18:16:00 GMT+0800 (China Standard Time)

Is this occurring only for one person?
I cannot reproduce it on windows. I downloaded latest core, Eluna-module and Eluna. Then I compiled and all succeeded with default settings.
Also travis is unable to reproduce the issue as seen here: https://github.com/azerothcore/azerothcore-wotlk/runs/722973823

I suggest you make sure you have latest core, eluna-module and Eluna.

Kaiser · Answer 4 · Sun May 31 2020 19:55:46 GMT+0800 (China Standard Time)

Is this occurring only for one person?
I cannot reproduce it on windows. I downloaded latest core, Eluna-module and Eluna. Then I compiled and all succeeded with default settings.
Also travis is unable to reproduce the issue as seen here: https://github.com/azerothcore/azerothcore-wotlk/runs/722973823

I suggest you make sure you have latest core, eluna-module and Eluna.

It builds fine on windows, this seems to be a linux specific (maybe mac osx?) issue.

Kitzunu · Answer 5 · Sun May 31 2020 20:10:29 GMT+0800 (China Standard Time)

afaik AzerothCore doesn't even build on Mac

Rochet2 · Answer 6 · Mon Jun 01 2020 03:42:46 GMT+0800 (China Standard Time)

@SamuelGogarty Are you having the same problem or are you just commenting on the issue?

Kaiser · Answer 7 · Mon Jun 01 2020 14:40:04 GMT+0800 (China Standard Time)

@SamuelGogarty Are you having the same problem or are you just commenting on the issue?

i am having the same issue, also on the same OS as OP

Kaiser · Answer 8 · Mon Jun 01 2020 14:40:53 GMT+0800 (China Standard Time)

afaik AzerothCore doesn't even build on Mac

there is official build documentation for mac osx.

Stefano Borzì · Answer 9 · Mon Jun 01 2020 20:19:57 GMT+0800 (China Standard Time)

I think that the problem is about how much the new compiler considers char* and std::string , now they different.

Analyzing the function:

#ifdef ELUNA
char* ResultSet::GetFieldName(uint32 index) const
{
    ASSERT(index < _fieldCount);
    return _fields[index].name;
}
#endif

It returns _fields[index].name; that is a std::string, so if you change char* into std::string it does not complain.

Here the fix: azerothcore/azerothcore-wotlk#3103

Stefano Borzì · Answer 10 · Mon Jun 01 2020 20:24:19 GMT+0800 (China Standard Time)

I forgot to say, that I am using:

clang and clang++ 6.0.0
gcc and g++ 7.5.0