0.16.0 fails to browserify

[Joey Baker]

Looks like there's a missing dep?

prova:browser Failed to browserify the source code. We're probably missing a module required. The error was: +15s

    Cannot find module 'sha.js' from '/…/node_modules/prova/node_modules/browserify/node_modules/crypto-browserify' /…/node_modules/prova/node_modules/browserify/node_modules/resolve/lib/async.js
                        v
    49.         else if (core[x]) return cb(null, x);
    50.         else cb(new Error("Cannot find module '" + x + "' from '" + y + "'"))
    51.     });
                        ^
    Error: Cannot find module 'sha.js' from '/…/node_modules/prova/node_modules/browserify/node_modules/crypto-browserify'

[Azer Koçulu]

hmm, I ran it on bunch of projects and didn't have any issue. Looks like an issue about the crypto package

btw you can try rm -rf node_modules/prova

[Joey Baker]

Huh. I just did a clean install of prova, and the problem did not go away. Somewhat interestingly, the error shows up twice per test run.

Here's the script we're using to run prova:

./node_modules/.bin/prova ./test/lib/*-test.js -b -e -l chrome -t hbsfy

[Azer Koçulu]

yeah, I actually started getting the same error. #53 upgraded browserify, some new settings are messed up as I see. any ideas @thealphanerd ?

[Azer Koçulu]

@joeybaker just published a patch as 1.16.1, does it fix ?

@thealphanerd were these options necessary? f805b23

[Myles Borins]

I believe those options are necessary for watchify

https://github.com/substack/watchify#var-w--watchifyb-opts

[Myles Borins]

I know that dominic tarr just updated crypto-browserify 3 hours ago... I'm digging in to see if this could be causing it

[Azer Koçulu]

@thealphanerd I was getting different path errors though

[Azer Koçulu]

try ./node_modules/prova/bin/prova test instead of global prova, that's how I reproduced the issue

[Myles Borins]

I have chased it down to the updated version of crypto-browserify.

if you manually cd into `node_modules/browserifyandnpm install crypto-browserify@3.3.0`` then all is well in the universe

[Myles Borins]

I'm going to run some diffs and see if I can chase down the error

This is breaking across all of browserify right now.

[Myles Borins]

browserify/crypto-browserify#73

[Myles Borins]

@azer you probably want to roll back the changes that you made to 0.16.1 as it will break watchify

[Myles Borins]

Just submitted a fix... hopefully this gets merged quickly browserify/crypto-browserify#74

[Azer Koçulu]

thanks a lot @thealphanerd

[Azer Koçulu]

reverted & released as 1.16.2

[Myles Borins]

!!!

[Joey Baker]

Thanks @thealphanerd!

[Myles Borins]

Landed browserify/crypto-browserify@5efa463
@azer you can close this issue.

If anyone has this problem try an uninstall / reinstall of prova and the issue should be fixed

[Azer Koçulu]

great, @thealphanerd thanks a lot