Aborting a build should not trigger Post-build Actions for CodeDeploy
Jason733i opened this issue · comments
Hi, I have a Post-build action setup for CodeDeploy and it incorrectly gets triggered regardless of the success of the build. It should not get triggered if the build fails or is aborted.
+1
+1
@Jmcfar this is pretty serious issue and caused us an unintentional deploy that actually led to a small downtime
Any chance this is reviewed and merged ASAP?
Edit: A way around this for now is env vars for the application name and setting it's value as the last build action, e.g. using EnvInject.
That way if the build fails, the last build action won't run, the env var won't be set and the CodeDeploy post build action will not deploy because it can't determine the application name.
Ugly.. but works
Is this bug likely to be addressed soon?
We just deployed broken code to production because of an aborted build.