awslabs / amazon-ecr-credential-helper

Automatically gets credentials for Amazon ECR on docker push/docker pull

Support c2s AWS environments

jrsherry opened this issue 2 years ago · comments

jrsherry commented 2 years ago

The regex for determining if the ECR URI is valid needs to be updated to support c2s AWS environments.

jrsherry commented 2 years ago

An example of this can be found here: https://github.com/kubernetes/kubernetes/pull/113087/files

jrsherry commented 2 years ago

One solution for this issue has been pulled here: #326

jrsherry commented 2 years ago

Here's a PR that picks up the pattern used in mainline kubernetes: https://github.com/awslabs/amazon-ecr-credential-helper/pull/434/files