awsdocs / amazon-ecs-developer-guide

The open source version of the Amazon ECS developer guide. You can submit feedback & requests for changes by submitting issues in this repo or by making proposed changes & submitting a pull request.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

startTimeout and stopTimeout need units - milliseconds, seconds, minutes?

ORESoftware opened this issue · comments

If you look here:

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-taskdefinition-containerdefinitions.html#cfn-ecs-taskdefinition-containerdefinition-user

StopTimeout
Time duration to wait before the container is forcefully killed if it doesn't exit normally on its own.

It doesn't tell us the units, I assume milliseconds, but it's pretty unclear, also for startTimeout.

The unit is seconds for both startTimeout and stopTimeout. We are pushing out an update to the documentation to make this clear. Thanks for bringing this to our attention!

np, ty tbh it was very unclear, I was in fact off by a factor of 1000 lulz