segment status is set to `fault` when in function `addError()` ?
wangzlei opened this issue · comments
Need to investigate this code is typo or not:
https://github.com/aws/aws-xray-sdk-node/blob/master/packages/core/lib/segments/segment.js#L268-L275
It is not a typo, just unfortunate naming :)
We have an equivalent method called addException in other SDKs to document a runtime exception's stacktrace. They all set fault flag. But in JS, there is no concept of Exceptions, JS only has Errors. So the method is the same as addException, but confusingly named addError.