Restore PSM3 transport for libfabric in .travis.yml

Question

Restore PSM3 transport for libfabric in .travis.yml

dmaryin opened this issue 2 years ago · comments

Hello aws_ofi_nccl maintainers,

I noticed that PSM3 provider was removed from libfabric build in your Travis config file, probably due to #85
As the issue has been resolved already, I guess this is not longer needed, could you please revisit this and re-enable PSM3 if possible?

BRs,
Denis.

Rashika Kheria · Answer 1 · Tue Feb 22 2022 03:53:35 GMT+0800 (China Standard Time)

Hey Denis,

We have removed any testing based off travis CI due to security concerns. We currently conduct manual testing internally which doesn't disable psm3 while building libfabric. The plan is to automate it for PR testing (The team is figuring out ways to integrate this with our infrastructure)

Hope that helps,
Rashika

Denis Maryin · Answer 2 · Tue Feb 22 2022 21:52:42 GMT+0800 (China Standard Time)

Hello Rashika,

Is it possible to remove .travis.yml completely then? It can be confusing for a beginner to see –disable-psm3 in CI-related files and easily lead to conclusion "oh, it probably doesn't work".

BRs,
Denis.

Rashika Kheria · Answer 3 · Wed Feb 23 2022 00:13:00 GMT+0800 (China Standard Time)

Yes, definitely. We will remove it as part of CI cleanup.

Denis Maryin · Answer 4 · Wed Feb 23 2022 00:51:00 GMT+0800 (China Standard Time)

Yes, definitely. We will remove it as part of CI cleanup.

Great, thanks!