Giters

aws / aws-ofi-nccl

This is a plugin which lets EC2 developers use libfabric as network provider while running NCCL applications.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Support FI_CONTEXT2

tmh97 opened this issue · comments

commented

Hey folks, we at Cornelis Networks are interested in adopting this ofi-nccl plugin.

If we create a patch to support fi_context2 structures, would that be something you are willing to entertain?

Thanks!

commented

@tmh97 We'd be happy to take a patch to support fi_context2. It should be relatively straight forward, although I'd probably have a preference for passing an array of 2 fi_context structures rather than a union or some nightmare casting, as we still have to support fi_context.

commented

@bwbarrett Thanks for the quick response, we'll open a PR with that patch in the near future. I'll make sure to opt for passing the array of 2 fi_context structs instead of unions/casting :)