aws-samples / serverless-jenkins-on-aws-fargate

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Agents deployed to ALB subnet?

joshuaganger opened this issue · comments

On line 30 of jenkins_image.tf this lne:

subnets = join(",", var.alb_subnet_ids)

appears to configure agents to deploy into the public subnet of the ALB. The diagram here: https://aws.amazon.com/blogs/devops/building-a-serverless-jenkins-environment-on-aws-fargate/ shows agents deploying into private subnets.

Should this line use var.jenkins_controller_subnet_ids or am I misunderstanding the purpose of this section?

Hi @joshuaganger, thank you for the hint! We have pushed the fix for this issue.