Clarify expected behavior if test stage fails
mdavis-xyz opened this issue · comments
Please modify the docstring comment for the test_secret function.
What is my code supposed to do if the test fails? Do I return False, or throw an exception? If an exception, which exception?
Thank you for your feedback. We have noted this as a feature request.
Hi mdavis. We expect that there are exceptions raised for any errors encountered. Which particular exceptions are irrelevant to Secrets Manager - we're tracking that the testSecret step failed, the rest would show up in your CloudWatch logs for debugging.
Ok, thanks for the explanation.
As someone in the target audience, that wasn't what I expected. So I've written a PR to clarify that.